bug#65666: closed (Lockfiles break package-vc-install-from-checkout)

[GNU bug Tracking System]

Your message dated Sun, 03 Sep 2023 07:03:09 +0000
with message-id <8734zv20ya.fsf@posteo.net>
and subject line Re: bug#65666: Lockfiles break package-vc-install-from-checkout
has caused the debbugs.gnu.org bug report #65666,
regarding Lockfiles break package-vc-install-from-checkout
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65666: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65666
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Lockfiles break package-vc-install-from-checkout
>
>
>
>
> Date: 
>
> Thu, 31 Aug 2023 14:47:48 -0700
>
>
>
>
> To reproduce: clone a repo, ensure that create-lockfiles is non-nil,
> edit a source file in the repo but do not save it, run
> package-vc-install-from-checkout on the repo.
>
> Backtrace:
>
> Debugger entered--Lisp error: (file-missing 
> "/home/joseph/.emacs.d/elpa/hyperdrive/.#hyperdrive.el")
>   
> comp-el-to-eln-filename("/home/joseph/.emacs.d/elpa/hyperdrive/.#hyperdrive.el")
>   (comp-clean-up-stale-eln (comp-el-to-eln-filename file))
>   (while (consp --cl-var--) (setq file (car --cl-var--)) 
> (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr 
> --cl-var--)))
>   (let* ((--cl-var-- (directory-files-recursively dir "\\.el\\'")) (file nil)) 
> (while (consp --cl-var--) (setq file (car --cl-var--)) (comp-clean-up-stale-eln 
> (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr --cl-var--))) nil)
>   (progn (let* ((--cl-var-- (directory-files-recursively dir "\\.el\\'")) (file 
> nil)) (while (consp --cl-var--) (setq file (car --cl-var--)) 
> (comp-clean-up-stale-eln (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr 
> --cl-var--))) nil))
>   (if (featurep 'native-compile) (progn (let* ((--cl-var-- 
> (directory-files-recursively dir "\\.el\\'")) (file nil)) (while (consp 
> --cl-var--) (setq file (car --cl-var--)) (comp-clean-up-stale-eln 
> (comp-el-to-eln-filename file)) (setq --cl-var-- (cdr --cl-var--))) nil)))
>   package--delete-directory("/home/joseph/.emacs.d/elpa/hyperdrive")
>   package-vc-install-from-checkout("~/.local/src/hyperdrive.el/" "hyperdrive")
>   funcall-interactively(package-vc-install-from-checkout 
> "~/.local/src/hyperdrive.el/" "hyperdrive")
>   command-execute(package-vc-install-from-checkout record)
>   execute-extended-command(nil "package-vc-install-from-checkout" nil)
>   funcall-interactively(execute-extended-command nil 
> "package-vc-install-from-checkout" nil)
>   command-execute(execute-extended-command)
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#65666: Lockfiles break package-vc-install-from-checkout
>
>
>
>
> Date: 
>
> Sun, 03 Sep 2023 07:03:09 +0000
>
>
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Joseph Turner <joseph@breatheoutbreathe.in>
> >> Cc: philipk@posteo.net, 65666@debbugs.gnu.org, adam.porter@47ap.net
> >> Date: Sat, 02 Sep 2023 10:15:48 -0700
> >> 
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> > Or make the REGEXP argument to directory-files-recursively more
> >> > specific, to reject lock files.
> >> >
> >> > But yes, the use of file-exists-p is not TRT, IMO.
> >> 
> >> See patch.
> >
> > Thanks, this LGTM.
>
> Agree, I have pushed the change to master.
>
>
> --- End Message ---