--- Begin Message ---
|
Subject: |
[PATCH] package-vc: Continue installing package when documentation build fails |
|
Date: |
Wed, 30 Aug 2023 23:26:35 -0700 |
In light of the recent fix regarding building documentation from
org-mode files, I think it makes sense to ensure that installation
continues even without documentation.
Joseph
0001-Continue-installing-package-when-documentation-build.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails |
|
Date: |
Sun, 03 Sep 2023 07:00:22 +0000 |
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> I think it would be better to wrap only the org code in the
>> `condition-case' body, ideally with a more specific error type (if that
>> doesn't exist, that is something we could mention to the Org
>> maintainers).
>
> The reason I wrapped both the org-export and makeinfo logic in
> condition-case is so that the makeinfo logic does not run when the
> org-export logic fails. Is there a better way?
>
> We could let-bind a flag like failed-org-export-p, then set it to t in
> the condition case handler, then only run makeinfo when
> failed-org-export-p is nil. Seems a bit ugly.
Oh right, never-mind then, I guess this is the simplest solution.
> The only define-error in org-mode that's relevant to org-export is not
> general enough:
>
> (define-error 'org-link-broken "Unable to resolve link; aborting")
Then this should be fine. I'll apply the changes the master. Thanks.
--- End Message ---