[debbugs-tracker] bug#37410: closed ([PATCH] Several doc fixes in package.el)

[GNU bug Tracking System]

Your message dated Sat, 21 Sep 2019 23:14:35 +0200
with message-id <CADwFkmkk2wP=+address@hidden>
and subject line Re: bug#37410: [PATCH] Several doc fixes in package.el
has caused the debbugs.gnu.org bug report #37410,
regarding [PATCH] Several doc fixes in package.el
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37410: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37410
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Several doc fixes in package.el Date: Sun, 15 Sep 2019 18:01:17 +0200

Seeing as the documentation in package.el leaves much to be desired, I
spent some time adding doc strings and fixing checkdoc and stylistic
errors.  I've attached a patch with my results, which should improve
the situation a little bit at least.  Is this okay to install?

Best regards,
Stefan Kangas

0001-Several-doc-fixes-in-package.el.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#37410: [PATCH] Several doc fixes in package.el
>
>
>
>
> Date: 
>
> Sat, 21 Sep 2019 23:14:35 +0200
>
>
>
>
> Stefan Kangas <address@hidden> writes:
>
> > Thanks for your detailed review.  I have attached an updated patch.
>
> No more comments in a week, so I've now pushed this as commit b86bc62ca5.
>
> > >>  (defun package-install-file (file)
> > >> -  "Install a package from a file.
> > >> +  "Install package from FILE.
> > >
> > > And this?
> >
> > I think the original is wordy for no reason, and imprecise: We do not
> > install just "a package" in general, but specifically the package
> > pointed to by FILE.  But if I'm the only one who feels that the terse
> > version is better, I'm willing to concede that point.
>
> In the end, I stuck with:
>
>     "Install a package from FILE."
>
> Best regards,
> Stefan Kangas
>
>
> --- End Message ---