[Elisp-code-dired] Re: [Q] Re: [PATCH] packages: dired to add itself to Help menu only once

[Adrian Aichner]

Michael Sperber <address@hidden> writes:

>> Notice the call to `add-menu-button'.  The original code in
>> `dired-install-menubar' calls it like:
>>
>>         (add-menu-button '("Help") (list "---"))
>>
>> Your patch agrees with this.  But the code you have cited as being
>> pre-your-patch calls it like:
>>
>>         (add-menu-button '("Help") "---")
>
> The change from the first call to the second was made after the last
> release.  (You can always check out the current development code on
> Savannah.)  I'm slightly confused over the discussion, but I don't see
> the problem you're describing with the released version.  I never saw
> it before (i.e. with the current XEmacs package).  I do see the
> duplicate separators with the development code, so I'll have to fix
> it there.  Just to make sure, Adrian, can you confirm if you see it

OK, thanks.

My patch won't automatically apply upstream.

I hope that's OK.

> with the actual current package code?

Nope, I was not aware that I was actually running with a local mod for
so long.

I installed dired-1.17 again, and it still has the previous old
breakage of the separator rendered as text with a empty submenu:

dired-1-17.png
Description: PNG image

-- 
Adrian Aichner
 mailto:address@hidden
 http://www.xemacs.org/