[Elisp-code-dired] [PATCH] packages: dired to add itself to Help menu only once

[Adrian Aichner]

Hi Mike, Norbert, could you please review/apply following patch.

This is current XEmacs cvs equivalent to upstream dired-version "7.13".

The annoyance was the addition of a separator at the end of the Help
menu for every directory newly visited.

It's probably not the best way to fix this.

Note to self: I have another change in that file:
-        (let ((extents (extent-list nil start end nil 'dired-file-name)))
+        (let ((extents (dired-filename-extents start end)))
(patch testing for Mike), so I cannot commit as is.

Best regards,

Adrian

packages ChangeLog patch:
Diff command:   cvs -q diff -U 0
Files affected: xemacs-packages/dired/ChangeLog

Index: xemacs-packages/dired/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/dired/ChangeLog,v
retrieving revision 1.21
diff -u -U0 -r1.21 ChangeLog
--- xemacs-packages/dired/ChangeLog     9 Apr 2005 20:24:54 -0000       1.21
+++ xemacs-packages/dired/ChangeLog     24 Jun 2005 22:16:02 -0000
@@ -0,0 +1,5 @@
+2005-06-25  Adrian Aichner  <address@hidden>
+
+       * dired-xemacs.el (dired-install-menubar): dired to add itself to
+       Help menu only once.
+

packages source patch:
Diff command:   cvs -f -z3 -q diff -u -w -N
Files affected: xemacs-packages/dired/dired-xemacs.el

Index: xemacs-packages/dired/dired-xemacs.el
===================================================================
RCS file: 
/pack/xemacscvs/XEmacs/packages/xemacs-packages/dired/dired-xemacs.el,v
retrieving revision 1.7
diff -u -w -r1.7 dired-xemacs.el
--- xemacs-packages/dired/dired-xemacs.el       9 Apr 2005 14:26:25 -0000       
1.7
+++ xemacs-packages/dired/dired-xemacs.el       24 Jun 2005 22:10:58 -0000
@@ -286,8 +286,10 @@
                    (menu (symbol-value (cdr pair))))
                (add-submenu nil (cons name menu)))))
           dired-menubar-menus))
-       (add-menu-button '("Help") (list "---"))
-       (add-submenu '("Help") (cons "Dired" dired-help-menu)))))
+       (unless
+           (car (find-menu-item current-menubar '("Help" "Dired")))
+         (add-menu-button '("Help") "---")
+         (add-submenu '("Help") (cons "Dired" dired-help-menu))))))
 
 (add-hook 'dired-mode-hook 'dired-install-menubar)
 
-- 
Adrian Aichner
 mailto:address@hidden
 http://www.xemacs.org/