[Duplicity-talk] [0.7.12] gpg.py and --pinentry-mode=loopback

[Richard McGraw]

Hello,

The man page of version 0.7.12 under '--use-agent' says:

              Note: Contrary to previous versions of duplicity, this
option will also be honored by GnuPG 2 and newer versions. If GnuPG 2
              is in use, duplicity passes the option
--pinentry-mode=cancel to the the gpg process unless --use-agent is
specified on the duplicity command line. This has the effect that GnuPG
2 uses the agent only if --use-agent is given, just like GnuPG 1.

But around line 140 of gpg.py the code is:

        if globals.use_agent and profile.gpg_version < (2, 0, 0):
            # gpg2 always requires the agent where gpg1 does not
            gnupg.options.extra_args.append('--use-agent')
        if profile.gpg_version >= (2, 1, 0):
            # This forces gpg2 to ignore the agent.
            # Necessary to enforce truly non-interactive operation.
            gnupg.options.extra_args.append('--pinentry-mode=loopback')

If globals.use_agent and profile.gpg_version >= (2, 1, 0) then
'--pinentry-mode=loopback' is added.

Also, the man page says '=cancel' not '=loopback'.