Re: [Duplicity-talk] Re: Duplicity 0.4.4.RC2 Ready

[Kenneth Loafman]

Kenneth Loafman wrote:
> Kenneth Loafman wrote:
>> Andreas Schildbach wrote:
>>> Kenneth Loafman wrote:
>>>
>>>> Added --time-separator <char> to allow users to change the time
>>>> separator from ':' to another character that will work on their
>>>> system.  HINT: For Windows SMB shares, use --time-separator='_'.
>>>> NOTE: '-' is not valid as it conflicts with date separator.
>>> I'm afraid this feature does not work yet (at least not with SMB shares):
>>>
>> <snip>
>>> I suspect the "_" substitution is not happening.
>> OK, now I'm getting frustrated.  I had a test case working on both Linux
>> and Windows.  Now it does not.  Must have screwed something else up with
>> the other changes.  More below.
> 
> I finally took the time to trace down why it did not work.  Somehow, I
> swapped a couple of lines in duplicity which caused the time string to
> be set *before* the option was read.  The attached patch fixes this.
> 
> I knew it had worked.  Now it will again.

Replying to self, not a good sign!  One more mod is needed to make
--remove-older-than work with --time-separator.  See attached.

...Ken

Index: duplicity-bin
===================================================================
RCS file: /sources/duplicity/duplicity/duplicity-bin,v
retrieving revision 1.27
diff -u -r1.27 duplicity-bin
--- duplicity-bin       29 Sep 2007 14:23:35 -0000      1.27
+++ duplicity-bin       10 Oct 2007 21:47:27 -0000
@@ -349,6 +349,7 @@
        """Start/end here"""
        dup_time.setcurtime()
        action = commandline.ProcessCommandLine(sys.argv[1:])
+       dup_time.setcurtime()
        col_stats = collections.CollectionsStatus(globals.backend,
                                                                                
          globals.archive_dir).set_values()
        log.Log("Collection Status\n-----------------\n" + str(col_stats), 8)

signature.asc
Description: OpenPGP digital signature