Re: [Denemo-devel] Another crash in master, 1.1.4 and 1.1.2

[Richard Shann]

On Sun, 2014-04-20 at 09:26 +0100, Richard Shann wrote:
> I think this crash is because you have re-written parseScripts()
> assuming that the command gets created before its properties are parsed,
> and this is not so. In 1.1.0 an empty command structure is set up which
> is filled with attributes and then the command is created from it.

I have pushed what I hope is the right fix for this.

Richard


> 
> Richard
> 
> 
> On Sat, 2014-04-19 at 13:57 +0100, Richard Shann wrote:
> > If you right click on a menu item and choose More Commands (or Choose
> > More Commands from the More menu) Denemo crashes when you choose to load
> > commands as well as shortcuts:
> > 
> > > 0x000000000045f9b7 in parseScripts (fallback=0x3bfbbc0 
> > > "/ObjectMenu/Score", 
> > >     cur=0x3be1b70, doc=0x3bfd400) at ../../denemo/src/core/keymapio.c:72
> > > 72                  command->after = (gchar*) xmlNodeListGetString (doc, 
> > > cur->xmlChildrenNode, 1);0x000000000045f9b7 in parseScripts 
> > > (fallback=0x3bfbbc0 "/ObjectMenu/Score", 
> > > 
> > 
> > 1.0.6 is ok in this respect.
> > 
> > Richard
> > 
> > 
> > 
> > _______________________________________________
> > Denemo-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/denemo-devel
> 
> 
> 
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/denemo-devel