Re: [Denemo-devel] Setting two-key shortcuts is broken.

[Richard Shann]

On Tue, 2014-04-22 at 16:29 +0100, Richard Shann wrote:
> In fact, if you try to set a shortcut via the command center on the last
> command in the whole keymap you get this:
> 
> (denemo:16716): GLib-GObject-WARNING **: /tmp/buildd/glib2.0-2.33.12
> +really2.32.4/./gobject/gsignal.c:2576: instance `0x5534a40' has no
> handler with id `16478'
This warning is when you steal the shortcut from another command - it
has been in Denemo since at least 1.1.0, it is not related.

the bottom line is that looking up the id from the action name works:

lookup_command_from_name (the_keymap, gtk_action_get_name (action));

while looking it up from the hash table 

g_hash_table_lookup (the_keymap->idx_from_name, command_name);

does not, but gives jumbled ids back.

I've put a hack into kbd-interface.c to use the lookup that works, but I
expect you will want to replace that with a proper fix.

Richard



> 
> Richard
> 
> 
> On Tue, 2014-04-22 at 16:06 +0100, Richard Shann wrote:
> > On Mon, 2014-04-21 at 08:51 +0100, Richard Shann wrote:
> > > If you try to set a two key shortcut
> > In fact any shortcut...
> > Eloi have you any idea what is going on? Depending on whether you are
> > trying to set the shortcut on the first command in the list or one
> > towards the end various things happen - usually off by one or two in the
> > list or (as in the case of setting a shortcut on the first command) it
> > works...
> > 
> > Richard
> > 
> > 
> > >  in the Command Center the shortcut
> > > gets put on the command before or after the one you selected not on the
> > > correct one. It shows as being on the correct one, but selecting another
> > > command and then returning shows that it is, in fact, set on a different
> > > one (before or after the correct one).
> > > 
> > > Richard
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > Denemo-devel mailing list
> > > address@hidden
> > > https://lists.gnu.org/mailman/listinfo/denemo-devel
> > 
> > 
> > 
> > _______________________________________________
> > Denemo-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/denemo-devel
> 
> 
> 
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/denemo-devel