Re: [Denemo-devel] Git master currently broken for command saving, command center operations ....

[Éloi Rivard]

It was part of my effort to factorize and reduce code in callbacks.h.

callbacks_cb functions called scheme callbacks, then sometimes displayhelper();

I deported displayhelper call in the scheme callbacks instead.

You are right, it may be called some more times now. Perhaps I can put some guards before those calls.

2013/11/25 Richard Shann <address@hidden>

On Mon, 2013-11-25 at 16:38 +0000, Richard Shann wrote:
> > I have commited two fixes. Can you please test ?
>
> The command center now seems to be working and I can save a new
> command.

I pulled and merged your work with mine and discovered a crash on
startup - it happens when Denemo is loading the last opened file.
I have fixed this by commenting out the call to displayhelper() in
commandfuncs.c
I noticed you inserted quite a few of these calls to displayhelper(),
and wanted to comment on this. I have no time in this email, but note it
is an expensive function and that I recall work being done to reduce the
number of calls to it in the past.

Richard

--
Éloi Rivard - address@hidden
       
« On perd plus à être indécis qu'à se tromper. »