Re: [Denemo-devel] Success building Denemo from git master for windows

[Richard Shann]

On Wed, 2013-03-06 at 06:56 -0600, Jeremiah Benham wrote:
> 
> 
> On Wed, Mar 6, 2013 at 3:11 AM, Richard Shann
> <address@hidden> wrote:
>         On Tue, 2013-03-05 at 13:13 -0600, Jeremiah Benham wrote:
>         > I have also built from master and compiled
>         --without-portmidi.
>         > Everything works great but it also hangs on exit. I wonder
>         if it is a
>         > threading issue. I don't know how threading works. I assume
>         that each
>         > thread need to closed on exit. How can we tell that this is
>         happening?
>         
>         
>         I just downloaded source =
>         'http://www.denemo.org/downloads/gub/libportmidi-0.218.tar.gz'
>         
>         and see this in portmidi.c
>         
>         static void prompt_and_exit(void)
>         {
>             char line[STRING_MAX];
>             printf("type ENTER...");
>             fgets(line, STRING_MAX, stdin);
>             /* this will clean up open ports: */
>             exit(-1);
>         }
>         
> 
> So I should delete everything from this function but the exit(-1)?
Well, IMHO a library call should *never* exit, it should always return
an error to the user who can decide what to do.
I have (I believe) tested this though without (seemingly) success, so I
will check in to git an attempt to fix this by the opposite route, of
just exiting the main thread. 

Richard

> 
> Jeremiah
>  
>         This will cause the hanging on exit, as it waits for stdin. If
>         this did
>         nothing instead, all would be well I think.
>         
>         Richard
>         
>         
>