[Denemo-devel] GTK3 branch was Re: Playback "cursor", aka playhead

[Richard Shann]

I have checked the screenshot stuff, working for gtk2 but disabled for
gtk3.
It turns out that the gtk3 code cannot be easily back ported to gtk2, so
I have both versions in screenshot.c
The gtk3 version is surrounded by #if 0 ... #endif as I have not been
able to compile it, and it is almost sure not to work even if it
compiles as it is just an initial hack of the gnome-screenshot code from
gtk3.
Can you check that this branch still compiles for gtk3 please? There are
only two issues with running the gtk3 branch version on gtk2 that I have
found so far
      * Initial Keysignature dialog broken
      * Horizontal scroll bar jammed wide open
I haven't looked at the DenemoGraphic stuff yet.

Richard


On Thu, 2011-11-24 at 11:16 -0600, Jeremiah Benham wrote:
> Sure, I won't be able to do it until later tonight because it is a holliday 
> here in the states. I must practice gluttony right now.
> 
> Jeremiah
> 
> Sent from my Samsung smartphone on AT&T
> 
> Richard Shann <address@hidden> wrote:
> 
> >Jermiah, can you reinstate screenshot.c into the build. You can surround
> >the contents of the file with #if 0 ... #endif and I will replace it
> >with something that compiles. I already have something that does the
> >capture but does not draw; I have the source code for the gtk3
> >screenshot program and can re-clone that code - this will have the
> >advantage that the new code is much more portable  - it should work on
> >windows as well.
> >Richard
> >
> >
> >On Thu, 2011-11-24 at 13:11 +0000, Richard Shann wrote:
> >> On Thu, 2011-11-24 at 12:03 +0000, Richard Shann wrote:
> >> > gtk-3 branch:
> >> >  I have fixed a crash when loading a new file (at gtk adjustment fires
> >> > in the gtk-3 branch, which does not happen in the old one), it may be
> >> > that the tempo and volume will need to be set later.
> >> >  The main draw window scroll bars are no longer working. 
> >> On a second look, it seems it is just the horizontal scroll that is
> >> wrong, the vertical one usually works, which is, I think the previous
> >> status of that (ie there is a bug in master for that).
> >> The Initial Keysignature dialog is broken; you can still do
> >> (d-InitialKey "G") to set one sharp etc.
> >> The "mode" stuff is not used in Denemo as far as I know - I don't know
> >> what whoever wrote it had in mind. I noticed there was a typo in it
> >> (locrain instead of locrian) which I think has gone now with your
> >> revisions.
> >> Richard
> >> 
> >> 
> >> 
> >> > I haven't
> >> > looked at that yet.
> >> > Richard
> >> > 
> >> > On Thu, 2011-11-24 at 00:16 -0600, Jeremiah Benham wrote:
> >> > > I have updated the gtk3 branch. It can now build with gtk < 2.24. 
> >> > > Evince is now required for both gtk2 and gtk3. Please go ahead and 
> >> > > test. It is currently up to date with master. 
> >> > > 
> >> > > Jeremiah
> >> > > 
> >> > > Sent from my Samsung smartphone on AT&T
> >> > > 
> >> > > Richard Shann <address@hidden> wrote:
> >> > > 
> >> > > >I have stripped out all the complication in drawing during playback
> >> > > >(which was intended to mitigate the lack of a separate priority thread
> >> > > >for playback), and the playhead is now behaving properly.
> >> > > >Please test.
> >> > > >It would be nice to include the GSOC work in the upcoming release if 
> >> > > >at
> >> > > >all possible.
> >> > > >Please let me know if there is anything I can help with.
> >> > > >
> >> > > >Richard
> >> > > >
> >> > > >
> >> > > >
> >> > > >_______________________________________________
> >> > > >Denemo-devel mailing list
> >> > > >address@hidden
> >> > > >https://lists.gnu.org/mailman/listinfo/denemo-devel
> >> > 
> >> > 
> >> > 
> >> > _______________________________________________
> >> > Denemo-devel mailing list
> >> > address@hidden
> >> > https://lists.gnu.org/mailman/listinfo/denemo-devel
> >> 
> >> 
> >> 
> >> _______________________________________________
> >> Denemo-devel mailing list
> >> address@hidden
> >> https://lists.gnu.org/mailman/listinfo/denemo-devel
> >
> >