Re: cygwin results [was: [platform-testers] new snapshot available: coreutils-8.22.151-37b36]

[Eric Blake]

On 07/14/2014 10:04 PM, Eric Blake wrote:
> On 07/14/2014 07:33 PM, Pádraig Brady wrote:
> 
>>> On 32-bit cygwin, a default ./configure didn't even get to 'make check'
>>> due to this error:
>>>
>>>   CCLD     src/make-prime-list.exe
>>> make[2]: *** No rule to make target 'src/libstdbuf.so', needed by
>>> 'all-am'.  Stop.
>>
>> Hmm, I'm guessing the make level failure is related to EXEEXT.
>> Notice how bin_PROGRAMS is adjusted in configure.ac
>> Probably pkglibexec_PROGS would need to be adjusted similarly.
>> Though that would not be the only thing needed to support the
>> stdbuf LDPRELOAD scheme on cygwin.
>> So perhaps this would avoid the immediate issue?
>>
>> diff --git a/configure.ac b/configure.ac
>> index b50f6e1..68bc011 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -473,7 +473,7 @@ AC_COMPILE_IFELSE(
>>    [stdbuf_supported=yes],
>>    [stdbuf_supported=no])
>>  AC_MSG_RESULT([$stdbuf_supported])
>> -if test "$stdbuf_supported" = "yes"; then
>> +if test "$stdbuf_supported" = "yes" && test -z "$EXEEXT"; then
>>    gl_ADD_PROG([optional_bin_progs], [stdbuf])
>>  fi
> 
> Possible; I'll give it a shot.  At this point, it requires a full
> autoreconf, so I spent some time getting coreutils.git up and running
> rather than just building from the snapshot.

Sorry for not responding earlier (and thus, 8.23 has the same issue).
But yes, I've tested this patch, and it does fix the immediate issue of
failed builds on cygwin.  Are you planning on turning it into a formal
patch for upstream?  I'd still like to get stdbuf ported there (it
_should_ be doable, since cygwin supports LD_PRELOAD), but that's a much
longer-term task.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature