[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: avoid static analysis warnings in ln.c
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] maint: avoid static analysis warnings in ln.c |
|
Date: |
Thu, 10 Apr 2014 22:20:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 04/10/2014 06:13 PM, Pádraig Brady wrote:
> * src/ln.c (do_link): It's not obvious that record_file() is a noop
> in the symlink case (in that case dest_set is NULL and so ignored).
> So to make it obvious, and to avoid false positives seen in coverity,
> add the explicit condition here.
Nice patch, thanks.
+1
Have a nice day,
Berny