coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: avoid static analysis warnings in ln.c


From: Pádraig Brady
Subject: [PATCH] maint: avoid static analysis warnings in ln.c
Date: Thu, 10 Apr 2014 17:13:04 +0100

* src/ln.c (do_link): It's not obvious that record_file() is a noop
in the symlink case (in that case dest_set is NULL and so ignored).
So to make it obvious, and to avoid false positives seen in coverity,
add the explicit condition here.
---
 src/ln.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/ln.c b/src/ln.c
index 6726699..42bccfc 100644
--- a/src/ln.c
+++ b/src/ln.c
@@ -343,7 +343,8 @@ do_link (const char *source, const char *dest)
     {
       /* Right after creating a hard link, do this: (note dest name and
          source_stats, which are also the just-linked-destinations stats) */
-      record_file (dest_set, dest, &source_stats);
+      if (! symbolic_link)
+        record_file (dest_set, dest, &source_stats);
 
       if (verbose)
         {
-- 
1.7.7.6




reply via email to

[Prev in Thread] Current Thread [Next in Thread]