Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

[Baruch Siach]

Hi Pádraig,

On Tue, Jan 14, 2014 at 06:46:14PM +0000, Pádraig Brady wrote:
> I noticed this uclibc build issue mentioned at:
> http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/73294
> 
> I sent a separate patch to gnulib to fix the direct issue there,
> however I was surprised that we were using the spawn-pipe module at all.
> 
> It seems since coreutils 8.16 we've pulled in these dependencies:
> 
>   pipe
>     spawn-pipe
>       posix_spawnp
>         posix_spawnp-internal
>           spawn
> 
> The change to add "pipe" was triggered by this GNULIB_POSIXCHECK result:
>  "call to 'pipe' declared with attribute warning: pipe is unportable -
>   use gnulib module pipe-posix for portability [-Werror]"
> 
> So I think we really only need to include pipe-posix instead,
> which is what the attached patch does.
> 
> The build error is a bit surprising as it suggests that uclibc builds
> are broken since 8.16? Or maybe uclibc has recently moved posix_spawn() -lrt?
> In any case these two fixes should avoid the issue for future coreutils 
> releases.

I see this patch now in git. But this patch alone, even when combined with the 
following one (9a115f3e24), doesn't fix the build when applied on top of 8.21 
(the current Buildroot version). Is there anything missing? Should I rerun 
./bootstrap?

baruch

> From 01a37162ea07e855011389f66053ee430053911a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Tue, 14 Jan 2014 18:23:44 +0000
> Subject: [PATCH] build: avoid unneeded spawn-pipe gnulib module
> 
> * bootstrap.conf: Reference the used pipe-posix module
> rather than the uneeded and larger spawn-pipe module,
> which the pipe module was the deprecated equivalent of.
> Note the spawn-pipe module had build issues on uclibc,
> which is addressed in a separate gnulib patch.
> ---
>  bootstrap.conf |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/bootstrap.conf b/bootstrap.conf
> index d3db84b..98e83bb 100644
> --- a/bootstrap.conf
> +++ b/bootstrap.conf
> @@ -177,7 +177,7 @@ gnulib_modules="
>    pathmax
>    perl
>    physmem
> -  pipe
> +  pipe-posix
>    posix-shell
>    posixtm
>    posixver


-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - address@hidden - tel: +972.2.679.5364, http://www.tkos.co.il -