coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] build: avoid unneeded spawn-pipe gnulib module


From: Pádraig Brady
Subject: [PATCH] build: avoid unneeded spawn-pipe gnulib module
Date: Tue, 14 Jan 2014 18:46:14 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

I noticed this uclibc build issue mentioned at:
http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/73294

I sent a separate patch to gnulib to fix the direct issue there,
however I was surprised that we were using the spawn-pipe module at all.

It seems since coreutils 8.16 we've pulled in these dependencies:

  pipe
    spawn-pipe
      posix_spawnp
        posix_spawnp-internal
          spawn

The change to add "pipe" was triggered by this GNULIB_POSIXCHECK result:
 "call to 'pipe' declared with attribute warning: pipe is unportable -
  use gnulib module pipe-posix for portability [-Werror]"

So I think we really only need to include pipe-posix instead,
which is what the attached patch does.

The build error is a bit surprising as it suggests that uclibc builds
are broken since 8.16? Or maybe uclibc has recently moved posix_spawn() -lrt?
In any case these two fixes should avoid the issue for future coreutils 
releases.

thanks,
Pádraig.

Attachment: pipe-posix.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]