Re: [PATCH] tests: avoid FP failure when cp fails for /proc/cpuinfo

[Bernhard Voelker]

On 01/09/2014 12:56 AM, Pádraig Brady wrote:
> Yes it seems that qemu-arm64 emulates access to /proc/cpuinfo:
> https://github.com/susematz/qemu/blob/aarch64-1.6/linux-user/syscall.c
> 
> This passes for me on an aarch64 baremetal system:
> 
>  test "$(stat -c %i /proc/cpuinfo)" = "$(stat -c %i /proc/cpuinfo)" ||
>   skip_ '(emulated?) /proc/cpuinfo inode number changed.'
> 
> Your cp error comparison is more direct and is better
> protection against this issue.
> 
> So please push your patch.

Thanks for the additional lookup and the review of the patch.

I'll change the commit message to emphasize that it's a problem
with emulated aarch64 rather than an issue of aarch64 per se:

- On aarch64, cp fails to copy /proc/cpuinfo because the inode number
- seems to change between the initial stat() call and copying the file:
+ On emulated aarch64 systems like in the qemu-based OpenBuildService
+ of openSUSE, cp fails to copy /proc/cpuinfo because the inode number
+ changes between the initial stat() call and copying the file:

Have a nice day,
Berny