Re: [PATCH] maint: update help2man to 1.43.3

[Bernhard Voelker]

[re-adding the list]

On 09/10/2013 10:36 AM, Pádraig Brady wrote:
> On 09/10/2013 07:03 AM, Bernhard Voelker wrote:
>> On 09/10/2013 04:40 AM, Pádraig Brady wrote:
>>> http://hydra.nixos.org/build/6038769 is failing with:
>>>
>>> Can't locate Locale/gettext.pm in @INC
>>> BEGIN failed--compilation aborted at ./man/help2man line 28.
>>
>> ouch, sorry.
>> The following patch should fix it.
> 
> Thanks for the quick fix.
> Please push.

Not that quick: besides the NLS issue above, the is yet another
one:

The files help2man.{in,diff} are missing in the distribution:

  make[2]: *** No rule to make target `man/help2man.in', \
  needed by `man/help2man'.  Stop.

And this in turn means that we'd need patch(1) in a distribution
build.  I'd like to avoid this new dependency.
In the coreutils-specific 'help2man.diff', there are 2 things
going on:
a) Remove the line
   "For complete documentation, run: info coreutils 'PRG invocation'"
   This can be done with a `sed '/For complete/d'` afterwards.
b) Changing the pointer to the info page from "info PRG" to
   "info coreutils 'PRG invocation'".
   We can use help2man's --info-page=... option for this.
After that, we can use the original 'help2man' without the need
for patching it in the distribution tarball.
I'll come up with a patch soon.

Have a nice day,
Berny