Re: [Bug-xorriso] building libisofs-1.4.4, libburn-1.4.4, libisoburn-1.4.4 on OpenBSD

[Thomas Schmitt]

Hi,

first question:

What was the error message without #include <pthread.h> before
#include "xorriso_private.h" ?

Do you see special reasons not to put the #include <pthread.h> into
xorriso/xorriso_private.h rather than into all its includers ?

-------------------------------------------------------------------------

There is a bug in your changeset which you should fix before testing.
The non-signal count must be decremented to 11, after you removed SIGPWR
and thus must be set inside the new #if text blocks:

===========================================================================
--- libburn-1.4.4.orig/libburn/os-netbsd.h      Fri Jul  1 20:25:22 2016
+++ libburn-1.4.4/libburn/os-netbsd.h   Wed Jul 20 12:05:42 2016
@@ -34,10 +34,17 @@
 #define BURN_OS_SIGNAL_COUNT 20
 
 /** To list all signals which shall surely not be caught */
+#if defined(__NetBSD__)
 #define BURN_OS_NON_SIGNAL_MACRO_LIST \
  SIGKILL, SIGURG, SIGSTOP, SIGTSTP, SIGCONT, \
  SIGCHLD, SIGTTIN, SIGTTOU, SIGIO, SIGWINCH, \
  SIGINFO, SIGPWR
+
+ /* The number of above list items */
+ #define BURN_OS_NON_SIGNAL_COUNT 12
+#elif defined(__OpenBSD__)
+#define BURN_OS_NON_SIGNAL_MACRO_LIST \
+ SIGKILL, SIGURG, SIGSTOP, SIGTSTP, SIGCONT, \
+ SIGCHLD, SIGTTIN, SIGTTOU, SIGIO, SIGWINCH, \
+ SIGINFO
+
+ /* The number of above list items */
+ #define BURN_OS_NON_SIGNAL_COUNT 11
+#endif
-
- /* The number of above list items */
- #define BURN_OS_NON_SIGNAL_COUNT 12


/* The maximum size for a (SCSI) i/o transaction */
===========================================================================

Meanwhile it looks much like NetBSD and OpenBSD will indeed share their
operating system adapter.


Have a nice day :)

Thomas