[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-recutils] Python support

From: Jose E. Marchesi
Subject: Re: [bug-recutils] Python support
Date: Tue, 09 Jul 2013 19:34:37 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Hi Maninya.
    My Github repo:
    recutils.c - C program that will provide the interface to Python.
    recutils_stubs.py - How the functions would look like in Python. Also
    my base to know all the required functions.

Thanks.  I have got several comments.  See them below.
    1) Please check the stubs file which contains some functions that
    would be used in Python. I have begun writing functions to parse files
    first. The function RecDb_loadfile() loads a rec file into the
    database. Please let me know to what level the C functions need to be
    exposed in Python. 

- The recutils.c file will compile into a pythong module, isnt it?  That
  is a shared object.  Is that correct?

- Please follow the GNU coding standards for C code contributed for
  recutils.  This including formatting rules, naming, indentation, etc.
  See www.gnu.org/prep/standards for details.

- I would prefer to use lower case letters and underscores for C
  identifiers, even if the convention in Python/C seems to be different.
  Mixed case is not a good idea in case-sensitive languages.

    2) Please let me know if this approach is alright.

Look correct to me.

    3) Shall I use pip for installation? Setup.py seems a bit messy, and
    we can't uninstall easily.

Care to elaborate?  What is pip and how does it differentiates to having
a setup.py file?

Also, I would much prefer you to work in a branch in the official
recutils repo.  In this way we can integrate the plugin in the recutils
source tree right from the beginning, substituting the preliminary work
I did in the recutils/python subdirectory.

You will need to create a savannah account first, and then request
membership to the 'recutils' project.  Tell me when that is done so I
can add you to the project and create the branch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]