Re: GNU make 4.2.90 release candidate available

[Eli Zaretskii]

> Date: Wed, 28 Aug 2019 12:18:13 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden
> 
> "One or two"?  I have 297 failures.  Many of them due to exit status
> incompatibility, like this:
> 
>   features/include ........................................ Error running 
> D:/gnu/make-4.2.90-guile/GccRel/gnumake.exe (expected 0; got 512): 
> 'D:/gnu/make-4.2.90-guile/GccRel/gnumake.exe' '-f' 
> 'work/features/include.mk.9'

Quite a few failures are due to the .exe extension, for example:

  *** work/features/double_colon.base.8 2019-08-28 12:48:16.365375000 +0300
  --- work/features/double_colon.log.8  2019-08-28 12:48:16.365375000 +0300
  ***************
  *** 1,3 ****
    ok
  ! gnumake.exe: Circular d <- d dependency dropped.
    oops
  --- 1,3 ----
    ok
  ! gnumake: Circular d <- d dependency dropped.
    oops

This is because we chop off the .exe extension in main.c, but the test
driver misses that:

  D:\gnu\make-4.2.90-guile\tests>run_make_tests -debug -make 
..\GccRel\gnumake.exe features/double_colon
  Opened unreadable file!  Skipping related tests.
  Failed to open D:/gnu/make-4.2.90-guile/tests/../config.status: No such file 
or directory at .\run_make_tests.pl line 83.

  DEBUG ON
  OS name = '(something posixy)'
  'sh' is not recognized as an internal or external command,
  operable program or batch file.
  'sh' is not recognized as an internal or external command,
  operable program or batch file.
  Port type:  W32
  Make path:  D:/gnu/make-4.2.90-guile/GccRel/gnumake.exe
  Shell path: sh.exe
  #PWD#:      D:\gnu\make-4.2.90-guile\tests
  #PERL#:     D:/usr/Perl/bin/perl.exe
  #MAKEPATH#: D:/gnu/make-4.2.90-guile/GccRel/gnumake.exe
  #MAKE#:     gnumake.exe

There are several problems here:

  . it attempts to run 'sh'
  . it decides that the shell is sh.exe
  . it decides that make_name is gnumake.exe

The latter is what causes false alarms in several tests, because the
test driver expects Make to identify itself as "gnumake.exe", whereas
it actually says "gnumake".

Suggestions how to fix that?