Re: GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

[Dennis Clarke]

On 8/26/19 4:32 PM, Paul Smith wrote:
> On Mon, 2019-08-26 at 16:19 -0400, Dennis Clarke wrote:
> > Testing on a few system and seems to fail the testsuite in various
> > ways on multiple systems. Does not compile on FreeBSD 12.0-RELEASE-
> > p10 amd64 with LLVM/Clang thus :
>
> Thanks Dennis.
>
> Please note that glob/fnmatch/getopt are not technically supported by
> GNU make, so I don't apply patches for them to fix warnings unless they
> are actual errors in the code.  Ditto for general code cleanup to these
> files.

Sadly I just wrote a 600 line patch. Fixes the issues and the warnings
and the point type mismatch.

> I recommend you don't compile with -Werror.

I tend to be a bit pedantic on a release candidate just to shake out the
code.

> If you find warnings to other files in src/ I'm interested in that.
>
> To fix this we'd need to start using the current gnulib versions of
> these files instead of the old ones we have now, and then if there are
> broken things they can get fixed there.

   * nod *

> As an example, when I run the regression tests on MacOS one of them
> fails in the symlink tests because (I believe) it's using the older
> glob.c/fnmatch.c we provide.  On GNU/Linux we use the versions that are
> provided with the system libc (because it's glibc).
>
> The reason this is difficult is because I'm not sure that the gnulib
> versions of glob/fnmatch work well with Windows (and VMS?)... or if
> they do what the best way to integrate them with gnu make is.  I'll
> look into it.

Well I am getting consistent results here on a number of systems across
various OS and platform architectures.  A few of them fail in the test
functions/wildcard and I see :

vesta$
vesta$ uname -apKU
FreeBSD vesta 12.0-RELEASE-p10 FreeBSD 12.0-RELEASE-p10 GENERIC  amd64 
amd64 1200086 1200086
vesta$ cc --version
FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on 
LLVM 6.0.1)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin
vesta$ find . | grep 'diff'
./tests/work/functions/wildcard.diff.7
vesta$ cat ./tests/work/functions/wildcard.diff.7
*** work/functions/wildcard.base.7      Mon Aug 26 21:30:53 2019
--- work/functions/wildcard.log.7       Mon Aug 26 21:30:53 2019
***************
*** 1 ****
! __ldir
--- 1 ----
!
vesta$

OKay over on ppc64 FreeBSD 13-CURRENT I see the exact same result while
using gcc 8.2.0 there.

Debian Linux "sid" on i686 with gcc 9.2.0 throws a ton of failures :

esther$
esther$ uname -a
Linux esther 5.2.0-2-686 #1 SMP Debian 5.2.9-2 (2019-08-21) i686 GNU/Linux
esther$ gcc --version
gcc (Debian 9.2.1-4) 9.2.1 20190821
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

esther$

esther$ find . | grep 'diff'
./tests/work/targets/SECONDARY.diff.3
./tests/work/targets/INTERMEDIATE.diff.2
./tests/work/targets/INTERMEDIATE.diff.5
./tests/work/targets/SECONDARY.diff.2
./tests/work/features/archives.diff.1
./tests/work/features/archives.diff.4
./tests/work/features/reinvoke.diff.1
./tests/work/features/archives.diff.2
./tests/work/features/archives.diff.6
./tests/work/features/output-sync.diff.12
./tests/work/features/output-sync.diff.11
./tests/work/features/archives.diff.3
./tests/work/features/reinvoke.diff.3
./tests/work/features/reinvoke.diff
./tests/work/features/archives.diff.5
./tests/work/features/vpathplus.diff.3
./tests/work/features/reinvoke.diff.2
./tests/work/features/load.diff.3
./tests/work/options/symlinks.diff.1
./tests/work/options/symlinks.diff.6
esther$


I don't even know where to begin on that machine.

Debian 9.9 on 32-bit arm7 fails the wildcard test with identical
results to the FreeBSD systems :

arm7$ uname -a
Linux arm7 4.4.132+ #1 SMP Wed May 15 19:37:54 CST 2019 armv7l GNU/Linux
arm7$ cat /etc/debian_version
9.9
arm7$ gcc --version
gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

arm7$
arm7$ cat ./tests/work/functions/wildcard.diff.7
*** work/functions/wildcard.base.7      Mon Aug 26 19:14:47 2019
--- work/functions/wildcard.log.7       Mon Aug 26 19:14:47 2019
***************
*** 1 ****
! __ldir
--- 1 ----
!
arm7$


The Solaris 10 SPARC machine blows up in so many places I don't even
know where to begin. It compiles clean. Perfect with Oracle Studio c99
and with strict CFLAGS but the testsuite fails in a spectacular fashion:

beta$ find . | grep 'diff'
./tests/work/features/errors.diff.4
./tests/work/features/errors.diff.3
./tests/work/features/vpathplus.diff.2
./tests/work/features/archives.diff.10
./tests/work/features/load.diff.3
./tests/work/features/output-sync.diff.14
./tests/work/features/errors.diff.5
./tests/work/features/load.diff.4
./tests/work/features/grouped_targets.diff
./tests/work/features/errors.diff.6
./tests/work/functions/shell.diff.6
./tests/work/functions/shell.diff.5
./tests/work/functions/shell.diff.7
./tests/work/functions/wildcard.diff.7
beta$

------------------------------------------------------------------------------
             Running tests for GNU make on SunOS beta 5.10 sun4u
                               GNU Make 4.2.90
------------------------------------------------------------------------------

Finding tests...

.
.
.

features/archives ....................................... FAILED (11/12 
passed)
features/errors ......................................... FAILED (3/7 
passed)
features/grouped_targets ................................ FAILED (11/12 
passed)
features/load ........................................... FAILED (3/5 
passed)
features/output-sync .................................... FAILED (14/15 
passed)
features/vpathplus ...................................... FAILED (3/4 
passed)
functions/shell ......................................... FAILED (5/8 
passed)
functions/wildcard ...................................... FAILED (7/8 
passed)


So not sure where to begin here.


--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders NOT optional