Re: GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

[Paul Smith]

On Mon, 2019-08-26 at 16:19 -0400, Dennis Clarke wrote:
> Testing on a few system and seems to fail the testsuite in various
> ways on multiple systems. Does not compile on FreeBSD 12.0-RELEASE-
> p10 amd64 with LLVM/Clang thus :

Thanks Dennis.

Please note that glob/fnmatch/getopt are not technically supported by
GNU make, so I don't apply patches for them to fix warnings unless they
are actual errors in the code.  Ditto for general code cleanup to these
files.

I recommend you don't compile with -Werror.

If you find warnings to other files in src/ I'm interested in that.

To fix this we'd need to start using the current gnulib versions of
these files instead of the old ones we have now, and then if there are
broken things they can get fixed there.

As an example, when I run the regression tests on MacOS one of them
fails in the symlink tests because (I believe) it's using the older
glob.c/fnmatch.c we provide.  On GNU/Linux we use the versions that are
provided with the system libc (because it's glibc).

The reason this is difficult is because I'm not sure that the gnulib
versions of glob/fnmatch work well with Windows (and VMS?)... or if
they do what the best way to integrate them with gnu make is.  I'll
look into it.