Re: make check under Cygwin

[Paul Smith]

On Wed, 2013-09-25 at 11:30 +0200, Denis Excoffier wrote:
> Still experimenting 'make check' with Cygwin (without the spawn-patch,
> with --disable-load):
> 
> 1) In test_driver.pl, line 486 (look for "Test returned"), a comparison
> of $code against the value -1 is performed. However, 3 lines above the 
> same test is done. This looks strange.

It's not beautiful code, but it's not wrong.  However I rewrote this
function to be more clear.

> 2) In connection with (1) above, the category 'default_names' produces
> '*** Test returned 0' and this is considered to be $suite_passed = 0
> (no deletion of files, no incrementation of categories_passed etc.),
> however the category seems to pass since the "ok" string is printed.
> 
> If i apply (1) above, all is ok.
> I don't understand why this "Test returned 0" does not show up
> on other (eg Linux) platforms.

There is a bug in default_names; it's missing the final "1;".  That
means that the result of the last thing in that file will be used as the
return.  For case-sensitive filesystem versions of make that's an
unlink() which succeeds.  For case-insensitive filesystem versions of
make it's the if-statement test, which is false.

I've fixed default_names.

> 3) If the HOME env var is not set, one of the jobserver tests fails.
> Perhaps this test should not be launched if HOME is not set.

I changed this test to not require $HOME.