[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: make check under Cygwin
From: |
Pavel Fedin |
Subject: |
RE: make check under Cygwin |
Date: |
Thu, 03 Oct 2013 10:08:33 +0400 |
Hello!
> Please take a look at the change I made, it takes care of all those
> things at a price of only 5 changed lines.
I see. Should work, indeed. I'd say the resulting code is less optimal
(repeated conditions, strncpy() with length = 1) and a bit more difficult to
understand. But, after all, it's a matter of personal taste, so feel free to
ignore it. ;)
One more small note. Since EMX is an environment similar to Cygwin in
purpose (according to the description), i suggest that it has the same
property and should also understand both forms of path.
So, ok, i promise to take a look at my spawn patch on weekend. I remember
about env-variable agreement. :)
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia