[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: mail (next/previous)
From: |
Alain Magloire |
Subject: |
Re: mail (next/previous) |
Date: |
Wed, 13 Mar 2002 11:00:44 -0500 (EST) |
>
> > The current implementation of mail_next() is broken.
> > Will crash and burn(SIGSEGV) if you just hit return on the prompt.
>
> Hmm, didn't notice so far :(
>
> > But what's the right fix. I thought reading somewhere that
> > if you hit return on the mail prompt that it is equivalent
> > to "next" which prints the the next mail. But our implementation
> > of "next" just move the cursor does not print. And we have
> > a "previous" counterpart which decrements the cursor.
>
> Next should move the dot to the next non-deleted message and print it.
> Previous should behave the same way. As far as I know, all existing
> implementations follow this principle. I don't know about just hitting
> return, though. It seems a good idea to make it run "next". Maybe
> it would be better if it just repeated the last executed command?
Ok, commit some changes for the SIGSEGV and free(cmd).
change nex/previous to print the mail.
It felt funny after doing Java for so long to call (free)
and to play with pointers.