suggestion about nameing MU_STREAM_READ/WRITE...

[Sam Roberts]

Allo!

I was going through my notes, and maybe I'm a luser, but it took
me an hour of tracing through the code at one time to figure
out this, so:

Since supplying MU_STREAM_READ|MU_STREAM_WRITE causes mboxes to look
empty, perhaps it can be an error? I expect read and write. I
know it's like the unix file open flags (now) but the UNIX flags
are O_RDONLY and O_WRONLY, which suggest that they don't mix,
whereas read+write==read-AND-write... not.

My suggestion:

1 - check for (currently) subtly meaningless combination of
    MU_STREAM_READ|MU_STREAM_WRITE.

2 -

 a) change names to MU_STREAM_RDONLY and MU_STREAM_WRONLY

 -or-

 b) make MU_STREAM_READ|MU_STREAM_WRITE legal, and mean read+write,
    and for backwards compatibility leave MU_STREAM_RDWR but define
    it to be MU_STREAM_READ|MU_STREAM_WRITE.

Sam

-- 
Sam Roberts <address@hidden> (Vivez sans temps mort!)

rdwr.diff
Description: Text document