bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Indentation mistake


From: Collin Funk
Subject: Re: Indentation mistake
Date: Thu, 2 May 2024 20:51:21 -0700
User-agent: Mozilla Thunderbird

Hi Simon,

On 5/2/24 11:25 AM, Simon Josefsson via Bug reports for the GNU Internet 
utilities wrote:
>> Sadly, I cannot do this, at least not easily.  After installing GNU
>> indent, "make syntax-check" complains about many files:
>>
>>     $ indent --version
>>     GNU indent 2.2.12
> You need 2.2.13 :-)

I see that you added the 'syntax-check' for indent in Gnulib. One
minor problem though, it breaks if the user has an ~/.indent.pro. :)

I don't use indent much, so I forgot my repository where I store
dotfiles installs this:

    $ cat ~/.indent.pro 
    --gnu-style
    --no-tabs

Here lets check if the code is indented:

    $ make sc_indent | wc -l
    maint.mk: code format error, try "make indent"
    make: *** [maint.mk:1760: sc_indent] Error 1
    52751

I was confused for a bit until I saw that file.

   $ rm ~/.indent.pro
   $ make sc_indent | wc -l
   1

Indent has -npro that you can use to ignore the file which might be
good.

Or, consider --no-tabs like I use. That is the flag that causes
issues. See whois/whois.c in Emacs with 'whitespace-mode' for the mix
of tabs and spaces. I won't push my coding style on others any further
though. :)

Collin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]