bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Rephrase recent change history.


From: Alfred M. Szmidt
Subject: Re: [PATCH] Rephrase recent change history.
Date: Sat, 09 May 2020 05:33:57 -0400

   >    Complaints? Remarks? Opposition?
   > 
   >    For my part, this would put our controversy ad actam.
   > 
   > LGTM.

   What does the acrynom "LGTM" stand for?

Looks Good To Me.

   >    +       * ChangeLog: Rephrase description of some implemented changes.
   > 
   > We don't (generally) mention changes to random text files in the
   > repository; other than maybe "Updated." -- but its up to you if you
   > want to keep this or not.

   Well, our file ChangeLog can hardly be said to be a "random file"!

It isn't a source code file, which is what the ChangeLog tries to
track.  For "textual" changes we don't have (different from should) to
mention it.

   Observe that my change set rectifies incorrect mention of
   "dologout", "Usernaem", "callees", improves details of change set,
   and performs minor rephrasing of style, like reducing duplicate
   text. I had rather wanted comments on these points, than having to
   fumble with glyphs.

It looks good, I don't have much to say on the point.  Thank you for
taking the time to do it!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]