Re: [bug-inetutils] [PATCH] Make `logger' IPv6-capable.

[Alfred M. Szmidt]

   diff --git a/ChangeLog b/ChangeLog
   index c474101..b2df64d 100644
   --- a/ChangeLog
   +++ b/ChangeLog
   @@ -1,3 +1,16 @@
   +2011-01-18  Mats Erik Andersson <address@hidden>
   +
   +    * src/logger.c (host_family): New variable.
   +    (struct logger_sockaddr): New component SINET6.
   +    (open_socket): Implement new code based on getaddrinfo.
   +    These are conditioned on HAVE_DECL_GETADDRINFO and HAVE_IPV6.

If something is wraped around a CPP conditional, then we can write:

(open_socket) [HAVE_DECL_GETADDRINFO && HAVE_IPV6]: ...

   @@ -244,6 +371,10 @@ const char args_doc[] =3D "[MESSAGE]";
    const char doc[] =3D "Send messages to syslog";
   =20
    static struct argp_option argp_options[] =3D {
   +#if HAVE_IPV6
   +  {"ipv4", '4', NULL, 0, "use IPv4 for logging to host" },
   +  {"ipv6", '6', NULL, 0, "use IPv6 with a host target" },
   +#endif

What do you think about issuing a warning if IPv6 is not supported,
and falling back on IPv4?  It is nice if one can move scripts between
systems, without having to tweak them.  Mayve skip the two short
options, they don't seem to be very useful to me; or do other logger
implementations support them?

Other than that, OK.

Mats, I hope the sporadic nature of replying isn't frustrating. :-)
You send good patches, keep it up!