Re: [bug-inetutils] Re: [PATCH 1/4] ftp: rename ruserpass to avoid C library collision

[Alfred M. Szmidt]

   Simon Josefsson <address@hidden> writes:

   > Mike Frysinger <address@hidden> writes:
   >
   >> The C library itself defines a "ruserpass" function.  When linking
   >> statically, it is possible to hit a symbol collision linker error.
   >> So rename the local ftp version to "remote_userpass".
   >
   > Applied and pushed.  Next time, please include a patch for ChangeLog as
   > well.

   Btw, would it make sense to _use_ the glibc ruserpass symbol
   instead of providing our own implementation?  The glibc
   implementation looks similar to the one we have.

Yes it would make sense, or atleast use the system one if it exists.
It is a old BSDism from BSD4.4.

   On the other hand -- the function is not documented in the glibc
   manual nor is it a POSIX function, so I'm not sure how stable the
   glibc implementation should be considered to be.

We can trust the glibc interfaces to be stable, just because they are
not documented isn't a reason to dismiss them (many interfaces aren't
documented in the libc manual).