[bug-inetutils] Re: [PATCH 1/4] ftp: rename ruserpass to avoid C library collision

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> Mike Frysinger <address@hidden> writes:
>
>> The C library itself defines a "ruserpass" function.  When linking
>> statically, it is possible to hit a symbol collision linker error.
>> So rename the local ftp version to "remote_userpass".
>
> Applied and pushed.  Next time, please include a patch for ChangeLog as
> well.

Btw, would it make sense to _use_ the glibc ruserpass symbol instead of
providing our own implementation?  The glibc implementation looks
similar to the one we have.  On the other hand -- the function is not
documented in the glibc manual nor is it a POSIX function, so I'm not
sure how stable the glibc implementation should be considered to be.

/Simon