[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-inetutils] Re: man pages

From: Alfred M. Szmidt
Subject: [bug-inetutils] Re: man pages
Date: Tue, 08 Dec 2009 06:31:51 -0500

   1) All man pages are included in the 'make dist' archive.

         This means that everyone building from version controlled
         sources needs to have all tools enabled -- so Ludo really
         needs to install curses on his build machine for 'make dist'
         to work for him in the future.

And bison... Since ftpcmd.c needs to be generated from ftpcmd.y.

   2) Man pages are not _installed_ when a tool has been disabled with
      ./configure --disable-foo.

   Did we have any other goals here?

Not that I can see.  Super thanks for working on this!

Though a small note, the following ChangeLog entries don't follow GNU
practise, they describe the purpose of change, when they should
describe the actual code changes.  Take the first one as an example,
it introduces a new variable `all', modifies EXTRA_DIST, and
MAINTAINERCLEANFILES, none of which are mentioned.  So the ChangeLog
entry should mention those changes, could you fix that?

We also avoid wildcards, so the file renames should mention what file
they got renamed to, otherwise it is hard to search for `ftpd.h2m' to
see when it was introduced, moved, etc.

Descriprive comments should be in the source code, so why we use .h2m
as an extention instead of the (common?) .x should be in the
Makefile.am not in ChangeLog.

2009-12-08  Simon Josefsson  <address@hidden>

        * man/Makefile.am: Make sure that all man pages are included in
        the 'make dist' target.  Suggested by Alfred M. Szmidt

2009-12-08  Simon Josefsson  <address@hidden>

        * man/Makefile.am: Only enable building of man pages for tools
        that are enabled.  Reported by Ludovic Court�s <address@hidden>.
        * am/enable.m4: Specify a conditional for every tool.

2009-12-08  Simon Josefsson  <address@hidden>

        * man/Makefile.am: Rename *.x files to *.h2m, to use the same
        extension used in the help2man package itself.  It also a more
        symbolic name than *.x.
        * man/ftp.x: Rename to *.h2m.
        * man/ftpd.x: Likewise.
        * man/hostname.x: Likewise.
        * man/ifconfig.x: Likewise.
        * man/inetd.x: Likewise.
        * man/logger.x: Likewise.
        * man/ping.x: Likewise.
        * man/rcp.x: Likewise.
        * man/rexec.x: Likewise.
        * man/rexecd.x: Likewise.
        * man/rlogin.x: Likewise.
        * man/rlogind.x: Likewise.
        * man/rsh.x: Likewise.
        * man/rshd.x: Likewise.
        * man/syslogd.x: Likewise.
        * man/talk.x: Likewise.
        * man/talkd.x: Likewise.
        * man/telnet.x: Likewise.
        * man/telnetd.x: Likewise.
        * man/tftp.x: Likewise.
        * man/tftpd.x: Likewise.
        * man/traceroute.x: Likewise.
        * man/uucpd.x: Likewise.
        * man/whois.x: Likewise.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]