[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] moving initial common functions from ping6 and libpi

From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] moving initial common functions from ping6 and libping to ping_common -3
Date: Wed, 27 Aug 2008 17:38:25 -0400

   I cannot make it smaller then this. It includes some ground work, +
   moving two functions into ping_common.

Clearer is better than smaller.

   +2008-08-28  Rakesh Pandit <address@hidden>
   +    * ping/ping6.c, ping/libping.c, ping_common.c
   +    (_ping_setbuf, ping_set_data): Moved duplicate code for
   +    functions _ping_setbuf & ping_set_data to ping_common.c.
   +    Added IS_PING6 arguments to both of these functions.
   +    * ping_comman.h, ping.h, ping6.h: Moved common includes
   +    from ping6.c, ping.c, libping.c, etc. Moved ping_data
   +    from ping.h & ping6.h to ping_common.h Added union event
   +    & union ping_address to struct ping_data.
   +    * ping.c, ping6.c, libping.c, ping_timestamp.c, ping_echo.c, 
   +    Removed redundant header file includes.
   +    (send_echo): Added IS_PING6 argument to ping_set_data.
   +    Replaced all ping_dest with ping_address member address6
   +    in ping6.c and with ping_address memeber address at all
   +    places in ping.c, ping_timestamp.c, ping_echo.c etc.

Please, please see the other ChangeLog files on how to write them, and
the GNU Coding Standards.  You have not described how the code was
changed, and you have left out alot of details.  And are not following
coding conventions.

I will comment later this week on the code.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]