[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fatfs patch for writing support
From: |
Alfred M. Szmidt |
Subject: |
Re: Fatfs patch for writing support |
Date: |
Fri, 25 Jul 2003 00:26:23 +0200 |
> Can some please have a look at this patch too? (Alfred? :)).
>
> I don't remeber if Marcus commented about this (I have a vauge feeling
> that he did), but according to the GCS long if statments should be
> split before an operator. That is instead of writting like this:
>
> if (foo_this_is_long && bar > win (x, y, z) &&
> remaining_condition)
>
> you should write it like so:
>
> if (foo_this_is_long && bar > win (x, y, z)
> && remaining_condition)
Hmm, I thought I've fixed this. Was this in my code or in the
surrounding code?
Code that you wrote, and changed to be compliant with the GCS. See
diskfs_direnter_hard for one such example.