[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fatfs patch for writing support
From: |
Alfred M. Szmidt |
Subject: |
Re: Fatfs patch for writing support |
Date: |
Thu, 24 Jul 2003 11:01:56 +0200 |
Can some please have a look at this patch too? (Alfred? :)).
I don't remeber if Marcus commented about this (I have a vauge feeling
that he did), but according to the GCS long if statments should be
split before an operator. That is instead of writting like this:
if (foo_this_is_long && bar > win (x, y, z) &&
remaining_condition)
you should write it like so:
if (foo_this_is_long && bar > win (x, y, z)
&& remaining_condition)
As for comments about the patch, could you send it without fixing the
existing code to follow the GCS? It is far easier to look at it that
way; and formatting issues are easily solved by the person doing the
check-in of the file anyway (C-x h M-C-\, or GNU indent).