Re: NetBSD utimens, utimensat, etc. failures

[Collin Funk]

Hi Bruno,

On 5/20/24 3:54 AM, Bruno Haible wrote:
>> I'll leave it for review.
> 
> Looks good to me. Just please change the #if conditions to not test the
> *values* of __linux__, __sun, __NetBSD__. That is, the proper way to test
> for Linux, Solaris, NetBSD is
>   defined __linux__
>   defined __sun
>   defined __NetBSD__

Yeah, I noticed that after sending the diff. I think it shouldn't have
caused any problems since gcc defines them to 1 IIRC. But I agree
defined is better.

>> If it is okay I can push with documentation updates, xfail removal, 
>> ChangeLog.
> 
> Yes please!

Done in the two attached patches.

It looks like you added the UTIME_OMIT ctime bug to the documentation
in this commit:

  commit e6c7f8be2fe11e72c3fff2503be9ab3f798b787a
  Author: Bruno Haible <bruno@clisp.org>
  Date:   Sat Jul 25 23:27:40 2020 +0200

      doc: Update for NetBSD 7.1, 8.0, 9.0.

Not too sure if that was a mistake in the bulk doc update or if the
code wasn't updated. I think it should be correct now but feel free to
look into it more if you would like:

$ git diff e6c7f8be2fe11e72c3fff2503be9ab3f798b787a^ 
e6c7f8be2fe11e72c3fff2503be9ab3f798b787a doc/posix-functions/futimens.texi 
doc/posix-functions/utimensat.texi

Collin

0001-utimensat-utimens-Work-around-NetBSD-10.0-bugs.patch
Description: Text Data

0002-tests-Update-expected-tests-results-on-NetBSD.patch
Description: Text Data