[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: NetBSD utimens, utimensat, etc. failures
|
From: |
Bruno Haible |
|
Subject: |
Re: NetBSD utimens, utimensat, etc. failures |
|
Date: |
Mon, 20 May 2024 12:54:12 +0200 |
Hi Collin,
> This patch fixes all the failures in my NetBSD virtual machine.
>
> Essentially, NetBSD 10.0 has the same issues as Linux 2.6 hppa had for
> this code.
Great! I'm glad that you could do it by just combining existing workarounds.
> I'll leave it for review.
Looks good to me. Just please change the #if conditions to not test the
*values* of __linux__, __sun, __NetBSD__. That is, the proper way to test
for Linux, Solaris, NetBSD is
defined __linux__
defined __sun
defined __NetBSD__
> If it is okay I can push with documentation updates, xfail removal, ChangeLog.
Yes please!
Bruno