Re: BUG: Incorrect warning when multiple po/ directories used

[Bruno Haible]

Alexander Turbov wrote:

> Recently I wrote test project to explore how to configure with multiple po/ 
> directories and fount the wollowing incorrect warning:
> 
> config.status: executing default-1 commands
> config.status: creating bar/po/POTFILES
> config.status: creating bar/po/Makefile
> config.status: creating foo/po/POTFILES
> config.status: setting ALL_LINGUAS in configure.in is obsolete
> config.status: creating foo/po/Makefile
> 
> I know exactly that ALL_LINGUAS don't used in configure.in!!
> The problem is: when multiple po/ directories configured, ALL_LINGUAS used in 
> config.status commands remain its value after 1st cycle even if actualy not 
> used in configure.in, and in the next iteration warning will be issued...

Thanks for reporting this. Find attached a patch; it will be included in
gettext-0.11.6.

> In attached .tar.gz my test project.

Thanks for the nice test case. It also uncovers an automake bug.
A few remarks:
  - configure.in: <features.h> is not a standard header. Only glibc has it.
  - foo/po/Makevars.in: subdir = foo/po
  - foo/po/Makevars.in: top_builddir = ../..
    Using @top_builddir@ here is equivalent, but looks like overkill.

Bruno


*** gettext-0/m4/gettext.m4     2002-11-11 12:25:51.000000000 +0100
--- gettext-1/m4/gettext.m4     2003-01-08 01:41:02.000000000 +0100
***************
*** 438,450 ****
            # parameters.
            if test -f "$ac_given_srcdir/$ac_dir/LINGUAS"; then
              # The LINGUAS file contains the set of available languages.
!             if test -n "$ALL_LINGUAS"; then
                test -n "$as_me" && echo "$as_me: setting ALL_LINGUAS in 
configure.in is obsolete" || echo "setting ALL_LINGUAS in configure.in is 
obsolete"
              fi
              ALL_LINGUAS_=`sed -e "/^#/d" "$ac_given_srcdir/$ac_dir/LINGUAS"`
              # Hide the ALL_LINGUAS assigment from automake.
              eval 'ALL_LINGUAS''=$ALL_LINGUAS_'
              POMAKEFILEDEPS="$POMAKEFILEDEPS LINGUAS"
            fi
            case "$ac_given_srcdir" in
              .) srcdirpre= ;;
--- 438,453 ----
            # parameters.
            if test -f "$ac_given_srcdir/$ac_dir/LINGUAS"; then
              # The LINGUAS file contains the set of available languages.
!             if test -n "$OBSOLETE_ALL_LINGUAS"; then
                test -n "$as_me" && echo "$as_me: setting ALL_LINGUAS in 
configure.in is obsolete" || echo "setting ALL_LINGUAS in configure.in is 
obsolete"
              fi
              ALL_LINGUAS_=`sed -e "/^#/d" "$ac_given_srcdir/$ac_dir/LINGUAS"`
              # Hide the ALL_LINGUAS assigment from automake.
              eval 'ALL_LINGUAS''=$ALL_LINGUAS_'
              POMAKEFILEDEPS="$POMAKEFILEDEPS LINGUAS"
+           else
+             # The set of available languages was given in configure.in.
+             eval 'ALL_LINGUAS''=$OBSOLETE_ALL_LINGUAS'
            fi
            case "$ac_given_srcdir" in
              .) srcdirpre= ;;
***************
*** 509,515 ****
     [# Capture the value of obsolete ALL_LINGUAS because we need it to compute
      # POFILES, GMOFILES, UPDATEPOFILES, DUMMYPOFILES, CATALOGS. But hide it
      # from automake.
!     eval 'ALL_LINGUAS''="$ALL_LINGUAS"'
      # Capture the value of LINGUAS because we need it to compute CATALOGS.
      LINGUAS="${LINGUAS-%UNSET%}"
     ])
--- 512,518 ----
     [# Capture the value of obsolete ALL_LINGUAS because we need it to compute
      # POFILES, GMOFILES, UPDATEPOFILES, DUMMYPOFILES, CATALOGS. But hide it
      # from automake.
!     eval 'OBSOLETE_ALL_LINGUAS''="$ALL_LINGUAS"'
      # Capture the value of LINGUAS because we need it to compute CATALOGS.
      LINGUAS="${LINGUAS-%UNSET%}"
     ])