[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70541: track-changes-mode logs warnings (with input method, in Eglot
From: |
Stefan Monnier |
Subject: |
bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer) |
Date: |
Sun, 05 May 2024 10:57:51 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> Is this really the final word on this whole topic? The current
> solution involves a one shot addition to `post-command-hook` in Eglot
> and is really ugly. Can you really really no better solution so that
> Eglot is only compelled to send changes to the server once
> track-changes.el announces it safe to do so (and gives the change to
> send while it's at it?
Until we've gotten rid of all the code chunks that incorrectly use
`inhibit-modification-hooks` (which will take a lot of time since not
only we have to find them but we have to figure out why they used
`inhibit-modification-hooks` and then argue hard to get the change to be
accepted), I don't see a significantly simpler solution, no. 🙁
I mean, a simpler solution is to live with the performance bug, of course.
> Also, tangentially , can we get rid of the fboundp's and make the next GNU
> ELPA version run the same code as Emacs master's by depending on
> track-changes.el GNU core?
Yes, coming right up.
> Also also, can you fix indentation in the function that you recently
> touched in Eglot? (same goes for Philip, but I'll contact him
> separately).
Hmm... hadn't notice anything wrong. Will take a closer look, thanks
for the heads up.
Stefan
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Stefan Monnier, 2024/05/03
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Stefan Monnier, 2024/05/03
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Richard Copley, 2024/05/04
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Stefan Monnier, 2024/05/04
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Stefan Monnier, 2024/05/04
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Richard Copley, 2024/05/04
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Stefan Monnier, 2024/05/05
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), João Távora, 2024/05/05
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer),
Stefan Monnier <=
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), João Távora, 2024/05/05
- bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer), Stefan Monnier, 2024/05/05