[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode
From: |
Mattias Engdegård |
Subject: |
bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support |
Date: |
Mon, 6 Feb 2023 12:19:32 +0100 |
5 feb. 2023 kl. 21.36 skrev Jostein Kjønigsen <jostein@secure.kjonigsen.net>:
> Attached is a patch which codifies all these changes, and from what I can
> tell, still does the job. You make take it as is, or you may further work on
> it, if you think that is still needed.
Thank you! I translated the regexps to rx (which I personally find more
maintainable and has plenty of precedence in this context) and tightened them
up further. They are now anchored at beginning-of-line again, and file names
cannot start with whitespace (for disambiguation and speed).
I also removed the part that matches the actual message text since it isn't
needed, and it would highlight (with an underline in the standard theme) the
whole text which is a bit ungainly to read. If the message is multi-line, which
earlier examples in this discussions indicated might be the case, then only the
first would be highlighted this way which wasn't ideal either.
Patch attached, please tell me what you think.
Does tsc distinguish between warnings, errors, and 'informational' messages
(such as locations of interest that are not errors in their own right)? The
examples you supplied all had the word "error" in a prominent place.
It would be possible to join the two tsc rules into a single one which would be
slightly faster, but having them separate could also be an advantage since it
would allow for them to be disabled individually in case of clashes.
0001-Simplify-typescript-compilation-mode-patterns-bug-61.patch
Description: Binary data