[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode
From: |
Theodor Thornhill |
Subject: |
bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support |
Date: |
Sat, 04 Feb 2023 09:24:49 +0100 |
Theodor Thornhill <theo@thornhill.no> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Fri, 03 Feb 2023 06:30:29 +0100
>>> From: Theodor Thornhill <theo@thornhill.no>
>>> CC: 61104@debbugs.gnu.org, casouri@gmail.com
>>>
>>> On 2 February 2023 22:01:11 CET, "Jostein Kjønigsen"
>>> <jostein@secure.kjonigsen.net> wrote:
>>> >Any news on this one? Will this be merged? :)
>>> >
>>>
>>> My guess is that it should go on master. I'll look at it today - sorry it
>>> took some time :)
>>
>> I'm okay with installing this on emacs-29 if the patch looks good.
>> Typescript mode is new in Emacs 29, so it's okay to make this change
>> now. But please be sure that the relevant tests still pass, i.e. that
>> this change doesn't break something else in compilation-mode.
>>
>> Thanks.
>
> Ok, I'll do that then. I'll add this in addition in the next commit, if
> that's ok.
>
> Thanks, Jostein and Eli :)
The changes are now installed on the emacs-29 branch, thanks!
Closing this :)
Theo