[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53255: highlight-regexp should show faces with their properties appl
From: |
Juri Linkov |
Subject: |
bug#53255: highlight-regexp should show faces with their properties applied when selecting a face |
Date: |
Sat, 22 Jan 2022 20:51:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> It shouldn't be limited to hi-lock. It should be
>> for `read-face-name'.
>
> So I put the affixion thing into read-file-name and made hi-lock call
> read-file-name instead of doing the completion itself.
This has such regression that before it supported the following workflow:
in the minibuffer 'M-n M-n ...' used to pull hi-lock faces from the ordered
"future history" list. But read-face-name doesn't support this feature.
If highlight-regexp should use read-face-name, then this feature
could be added to read-face-name. Here is the simplest patch,
but it would be a tough task to explain the need of an additional
DEFAULTS arg in the documentation. An alternative would be to
rewrite read-face-name and keep cdr of the existing arg DEFAULT
for the future history of the minibuffer.
diff --git a/lisp/faces.el b/lisp/faces.el
index bb9b1e979f..7a1fae3669 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -1065,7 +1065,7 @@ invert-face
(defvar crm-separator) ; from crm.el
-(defun read-face-name (prompt &optional default multiple)
+(defun read-face-name (prompt &optional default multiple defaults)
"Read one or more face names, prompting with PROMPT.
PROMPT should not end in a space or a colon.
@@ -1129,7 +1129,7 @@ read-face-name
(dolist (face (completing-read-multiple
prompt
(completion-table-in-turn nonaliasfaces aliasfaces)
- nil t nil 'face-name-history default))
+ nil t nil 'face-name-history defaults))
;; Ignore elements that are not faces
;; (for example, because DEFAULT was "all faces")
(if (facep face) (push (intern face) faces)))
diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index 8df73b1d37..a6760580f8 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -729,7 +729,8 @@ hi-lock-read-face-name
face)
(if (and hi-lock-auto-select-face (not current-prefix-arg))
(setq face (or (pop hi-lock--unused-faces) (car defaults)))
- (setq face (symbol-name (read-face-name "Highlight using face"
defaults)))
+ (setq face (symbol-name (read-face-name "Highlight using face"
+ (car defaults) t (cdr
defaults))))
;; Update list of un-used faces.
(setq hi-lock--unused-faces (remove face hi-lock--unused-faces))
;; Grow the list of defaults.
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, (continued)
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/15
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/20
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/20
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/22
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face,
Juri Linkov <=
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/23
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/23
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/24
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15
bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/15
bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15