[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53255: highlight-regexp should show faces with their properties appl
From: |
Kévin Le Gouguec |
Subject: |
bug#53255: highlight-regexp should show faces with their properties applied when selecting a face |
Date: |
Fri, 21 Jan 2022 14:39:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> Great! A couple of nits:
>>
>> 1. Is there a reason why you went with (list "SAMPLE\t" "" face) instead
>> of (list face "" \tSAMPLE)? "(elisp) Completion Variables" says that
>> the completion goes first, then the prefix, then the suffix; I don't
>> know how hard a rule that is, however I do think the latter option
>> fares better when faced with variable heights.
>
> It looked really bad with the face names first, since they have wildly
> differing lengths.
… and so the samples would get misaligned? (Trying to make sure I
understand the issue)
IMO that's less annoying than the names being misaligned (since that
throws me off slightly when I'm looking them over to figure out what I
need to type), but YMMV.
(I'm still intrigued by the documentation of :affixation-function
though: it seems to me that it asks for (list COMPLETION PREFIX SUFFIX),
but obviously your code works…)
>> 2. As you can see on the screenshots, the prompt shows the default face
>> twice. I think fixing this is as simple as removing format-prompt
>> (patch also attached), but then again, I'm not thinking straight this
>> evening it seems.
>
> (hi-lock-read-face-name) doesn't seem to display the default twice in an
> emacs -Q?
It does here 😕
./src/emacs -Q
M-: emacs-repository-version
"1228ec3e1d7657c9eb50184719410f37ed0eb750"
M-: (hi-lock-read-face-name)
Highlight using face (default hi-yellow) (default hi-yellow):
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, (continued)
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/15
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/20
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/20
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Kévin Le Gouguec, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face,
Kévin Le Gouguec <=
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/22
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/21
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/22
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/23
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/23
- bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Lars Ingebrigtsen, 2022/01/24
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15
- bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Drew Adams, 2022/01/15
bug#53255: highlight-regexp should show faces with their properties applied when selecting a face, Juri Linkov, 2022/01/15