[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50344: C-x v keybinding for vc-print-branch-log
From: |
Juri Linkov |
Subject: |
bug#50344: C-x v keybinding for vc-print-branch-log |
Date: |
Thu, 07 Oct 2021 20:27:07 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> Thanks, two very minor doc comments:
>
>> +;;;###autoload
>> +(defun vc-retrieve-tag (dir name &optional branchp)
>> "For each file in or below DIR, retrieve their tagged version NAME.
>> NAME can name a branch, in which case this command will switch to the
>> named branch in the directory DIR.
>> @@ -2375,15 +2413,21 @@ vc-retrieve-tag
>> (read-directory-name "Directory: " default-directory nil t))))
>> (list
>> dir
>> - (vc-read-revision (format-prompt "Tag name to retrieve" "latest
>> revisions")
>> + (vc-read-revision (format-prompt
>> + (if current-prefix-arg
>> + "Branch name to retrieve"
>> + "Tag name to retrieve")
>> + "latest revisions")
>
> Mention prefix arg in the docstring?
Thanks for noticing, will be added in the next version of the patch.
>> +(defun vc-switch-branch (dir name)
>> + "Switch to the branch NAME in the directory DIR.
>> +If NAME is empty, it refers to the latest revisions of the current branch.
>> +Uses `vc-retrieve-tag' with the non-nil arg `branchp'."
>
> "latest revision" instead of plural?
This text was copied from vc-retrieve-tag, and Robert explained why
it's plural. But since this phrase is too confusing, maybe it would be
possible to rephrase it with a better text?
- bug#50344: C-x v keybinding for vc-print-branch-log, Juri Linkov, 2021/10/05
- bug#50344: C-x v keybinding for vc-print-branch-log, Juri Linkov, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Eli Zaretskii, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Juri Linkov, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Eli Zaretskii, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Dmitry Gutov, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Eli Zaretskii, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Dmitry Gutov, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Eli Zaretskii, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Dmitry Gutov, 2021/10/07
- bug#50344: C-x v keybinding for vc-print-branch-log, Eli Zaretskii, 2021/10/07