bug#7787: 23.2; wrong meaning for mouse-2 while in search mode

[Stefan Kangas]

Juri Linkov <juri@linkov.net> writes:

> Stefan, could you please help to reproduce the issue.
> What are the necessary steps?

Sorry for not following up on this sooner.

  0. emacs -Q
  1. M-: (setq mouse-yank-at-point t) RET
  2. double click any word to mark it
  3. C-s
  4. mouse-2 [with cursor still over the original window, not in
     minibuffer]

> I see that the existing implementation of isearch-mouse-2
> allows yanking the selection when clicked in the echo area,
> but when clicked in the buffer it goes into infinite recursion,
> because isearch-mouse-2 calls itself again.

This is what I see as well, on current master.

Using 26.3, it yanks the text at point in the original buffer.

> Should it yank the selection when clicked in the buffer too?

That was the requested behaviour AFAIU, yes.

Best regards,
Stefan Kangas