Re: ...Wrong email addresses for PR 'responsible' persons

[Chad Walstrom]

Nadim Shaikli <shaikli@yahoo.com> wrote:
> ### Patch - Begin
> --- gnatsweb.pl.orig  2004-11-05 12:09:49.000000000 -0800
> +++ gnatsweb.pl       2004-11-05 15:33:04.000000000 -0800
> @@ -2144,10 +2144,14 @@
>  # if it's not a full address, $site_mail_domain is appended first
>  sub make_mailto {
>      my $string = shift;
> -    if ($string !~ /@/) {
> -     $string = qq*<a href="mailto:${string}${site_mail_domain}";>$string</a>*;
> +    my $addr = exists($responsible_address{$string}) ?
> +       $responsible_address{$string} : $string;
> +    my $fullname = exists($responsible_fullname{$string}) ?
> +       $responsible_fullname{$string} : $string;
> +    if ($addr !~ /@/) {
> +     $string = qq*<a href="mailto:${addr}${site_mail_domain}";>$fullname</a>*;
>      } else {
> -     $string = qq*<a href="mailto:$string";>$string</a>*;
> +     $string = qq*<a href="mailto:$addr";>$fullname</a>*;
>      }
>      
>      return $string;
> ### Patch - End
> 
> Hope this gets included.

For what it's worth, I think this patch works beautifully.  We're using
it now at work and have had favorable remarks.  (I added the modified
sub call to our gnatsweb-site.pl file.)  Nadim, could you add this patch
to the http://savannah.gnu.org/patch/?group=gnats website?  Yngve will
see to it from there.

-- 
Chad Walstrom <chewie@wookimus.net>           http://www.wookimus.net/
           assert(expired(knowledge)); /* core dump */

signature.asc
Description: Digital signature