[address@hidden: Bug#280498: gnatsweb.pl: Wrong email addresses for PR 'responsible' persons]

[Chad Walstrom]

This PR and patch showed up in the Debian BTS.

-- 
Chad Walstrom <chewie@wookimus.net>           http://www.wookimus.net/
           assert(expired(knowledge)); /* core dump */
> --- Begin Message ---
>
>
>
> Subject: 
>
> Bug#280498: gnatsweb.pl: Wrong email addresses for PR 'responsible'	persons
>
>
>
>
> Date: 
>
> Tue, 09 Nov 2004 13:31:52 -0800
>
>
>
>
> Package: gnatsweb
> Version: 4.00-1
> Severity: normal
> File: gnatsweb.pl
> Tags: patch
>
> Gnatsweb seems to assume that the default responsible people will have
> the same email as the default domain which is not the case as is noted
> in the 'responsible' file within the "gnats-adm" directory.  Gnatsweb
> thus displays the wrong email addresses.  Some of our users also noted
> that they'd rather the 'responsible' person's fullname instead of their
> username.  Patch is noted below.
>
> ### Patch - Begin
> --- gnatsweb.pl.orig    2004-11-05 12:09:49.000000000 -0800
> +++ gnatsweb.pl 2004-11-05 15:33:04.000000000 -0800
> @@ -2144,10 +2144,14 @@
>  # if it's not a full address, $site_mail_domain is appended first
>  sub make_mailto {
>      my $string = shift;
> -    if ($string !~ /@/) {
> -       $string = qq*<a href="mailto:${string}${site_mail_domain}";>$string</a>*;
> +    my $addr = exists($responsible_address{$string}) ?
> +         $responsible_address{$string} : $string;
> +    my $fullname = exists($responsible_fullname{$string}) ?
> +         $responsible_fullname{$string} : $string;
> +    if ($addr !~ /@/) {
> +       $string = qq*<a href="mailto:${addr}${site_mail_domain}";>$fullname</a>*;
>      } else {
> -       $string = qq*<a href="mailto:$string";>$string</a>*;
> +       $string = qq*<a href="mailto:$addr";>$fullname</a>*;
>      }
>      
>      return $string;
> ### Patch - End
>
> Hope this gets included.
>
>  - Nadim
>
> -- System Information:
> Debian Release: testing/unstable
> Architecture: i386
> Kernel: Linux sina 2.4.22 #2 Thu Sep 18 20:47:45 PDT 2003 i686
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8
>
> Versions of packages gnatsweb depends on:
> ii  apache [httpd]              1.3.29.0.1-3 Versatile, high-performance HTTP s
> ii  apache2-mpm-prefork [httpd] 2.0.51-2     Traditional model for Apache2
> ii  perl [libmime-base64-perl]  5.8.4-2      Larry Wall's Practical Extraction 
> ii  perl-modules [libcgi-pm-per 5.8.4-2      Core Perl modules.
>
> -- no debconf information
>
> --- End Message ---

signature.asc
Description: Digital signature