Re: Attic cleanup

[Mark D. Baushke]

Derek Robert Price <derek@ximbiot.com> writes:

> >>I also do not see an easy way from a cvs command viewpoint to determine
> >>in sanity.sh that the Attic directory is being removed if that is what
> >>is considered proper.
> 
> That's easy, Mark.  Just `test -d $CVSROOT_DIRNAME/modulename/Attic'.

Yes, that works. I should avoid replies at ~4am local time, clearly sleep
was required at that time rather than responding to e-mail.

> As long as the test -d was in place, I'd trust user's to run sanity.sh
> on the appropriate filesystems as they found necessary.  Also, Paul,
> if you'd like to send a patch with test cases testing various CVS
> commands when the Attic is empty, I'd likely commit that.  Of course,
> if the Attic went away when empty, I suppose only the test that it was
> deleted would be necessary.  This would be less code in the test suite.

I don't know about you, but I typically only run the tests in the
default /tmp directory which is typically either a ufs (which is the
filesystem type I normally use for the repository anyway) or a memory
filesystem. I suppose we should encourage folks to run the tests in the
filesystems they are going to use...

> Of course, a new CVS running against an old repository might still
> need to handle empty Attics properly.  Maybe it's better to test
> against empty attics.

True.

        -- Mark